1
98%
master: 98%

Ran 25 Sep 2017 12:28PM UTC

Files 6

Run time 0s

Badge

Embed ▾

Committed 25 Sep 2017 12:26PM UTC coverage: 87.671% (+4.3%) from 83.333%

Job # 2.4.1, PUPPET_GEM_VERSION='~> 5' COVERAGE=yes

Build Type

push

travis-ci

Committed by

DavidS

Commit Message

Do not require the namevar to be called :name

This was a mistake. This is handled within puppet. This needs more work
around canonicalization to hide this from the provider. Currently the
apt_key prototype carries this:

```
  def canonicalize(context, resources)
    resources.each do |r|
      r[:name] ||= r[:id]
      r[:name] = if r[:name].start_with?('0x')
                   r[:name][2..-1].upcase
                 else
                   r[:name].upcase
                 end

      if r[:name].length != 40
        context.warning(r[:name], 'The name should be a full fingerprint (40 characters) to avoid collision attacks, see the README for details.')
        fingerprint = key_list_lines.select { |l| l.start_with?('fpr:') }
                                    .map { |l| l.split(':').last }
                                    .find { |fp| fp.end_with? r[:name] }
        r[:name] = fingerprint if fingerprint
      end

      r[:id] = r[:name]
    end
  end
```

and the whole :name/:id juggling should be done here instead.

Run Details

192 of 219 relevant lines covered (87.67%)

8.05 hits per line

puppetlabs / puppet-resource_api / 28 / 1
98%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 28.1 (2.4.1, PUPPET_GEM_VERSION='~> 5' COVERAGE=yes)

puppetlabs / puppet-resource_api / 28 / 1 98% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 28.1 (2.4.1, PUPPET_GEM_VERSION='~> 5' COVERAGE=yes)

puppetlabs / puppet-resource_api / 28 / 1
98%
master: 98%

README BADGES
x