28
98%

Ran 25 Sep 2017 12:28PM UTC

Jobs 1

Files 6

Run time 0s

Badge

Embed ▾

pending completion

Build # 28

Build Type

push

travis-ci

Committed by

DavidS

Commit Message

Do not require the namevar to be called :name

This was a mistake. This is handled within puppet. This needs more work
around canonicalization to hide this from the provider. Currently the
apt_key prototype carries this:

```
  def canonicalize(context, resources)
    resources.each do |r|
      r[:name] ||= r[:id]
      r[:name] = if r[:name].start_with?('0x')
                   r[:name][2..-1].upcase
                 else
                   r[:name].upcase
                 end

      if r[:name].length != 40
        context.warning(r[:name], 'The name should be a full fingerprint (40 characters) to avoid collision attacks, see the README for details.')
        fingerprint = key_list_lines.select { |l| l.start_with?('fpr:') }
                                    .map { |l| l.split(':').last }
                                    .find { |fp| fp.end_with? r[:name] }
        r[:name] = fingerprint if fingerprint
      end

      r[:id] = r[:name]
    end
  end
```

and the whole :name/:id juggling should be done here instead.

Run Details

192 of 219 relevant lines covered (87.67%)

8.05 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	28.1 (2.4.1, PUPPET_GEM_VERSION='~> 5' COVERAGE=yes)	25 Sep 2017 12:28PM UTC	0	87.67	Travis Job 28.1

Source Files on build 28

Detailed source file information is not available for this build.

puppetlabs / puppet-resource_api / 28
98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 28

puppetlabs / puppet-resource_api / 28 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 28

puppetlabs / puppet-resource_api / 28
98%

README BADGES
x