4
94%
dev: 94%

Ran 20 Aug 2017 06:48PM UTC

Files 283

Run time 14s

Badge

Embed ▾

Committed 20 Aug 2017 06:29PM UTC coverage: 93.757%. Remained the same

Job # TOXENV=py36

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

LIFX: avoid rare NoneType errors (#9054)

* Get full multizone state during registration

We used to rely on the periodic update to get the state of each zone, only
establishing the number of zones during registration. This resulted in errors
if the current state was needed for a partial color change before the first
async_update happened.

Now we do a full update before adding the light. Thus async_update can no
longer assume device.color_zones to be defined and must instead use the
response message to decide the total number of zones.

* Insist on getting the initial state

If a response to the initial state query is lost we used to just carry on.
This resulted in type errors when we next tried to access the undefined state.

After this commit the light is not added before we have the full state.

This scenario mostly happens when something is misbehaving and the type errors
were actually useful in figuring out what happend. So an error message is
logged in their place.

* Remove lint

Run Details

24643 of 26284 relevant lines covered (93.76%)

0.94 hits per line

home-assistant / home-assistant / 28292 / 4
94%
dev: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 28292.4 (TOXENV=py36)

home-assistant / home-assistant / 28292 / 4 94% dev: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 28292.4 (TOXENV=py36)

home-assistant / home-assistant / 28292 / 4
94%
dev: 94%

README BADGES
x