28292
94%

Ran 20 Aug 2017 06:40PM UTC

Jobs 5

Files 283

Run time 7min

Badge

Embed ▾

pending completion

Build # 28292

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

LIFX: avoid rare NoneType errors (#9054)

* Get full multizone state during registration

We used to rely on the periodic update to get the state of each zone, only
establishing the number of zones during registration. This resulted in errors
if the current state was needed for a partial color change before the first
async_update happened.

Now we do a full update before adding the light. Thus async_update can no
longer assume device.color_zones to be defined and must instead use the
response message to decide the total number of zones.

* Insist on getting the initial state

If a response to the initial state query is lost we used to just carry on.
This resulted in type errors when we next tried to access the undefined state.

After this commit the light is not added before we have the full state.

This scenario mostly happens when something is misbehaving and the type errors
were actually useful in figuring out what happend. So an error message is
logged in their place.

* Remove lint

Run Details

24649 of 26284 relevant lines covered (93.78%)

2.81 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	28292.1 (TOXENV=lint)	20 Aug 2017 06:48PM UTC		Travis Job 28292.1
2	28292.2 (TOXENV=py34)	20 Aug 2017 06:42PM UTC	93.76	Travis Job 28292.2
3	28292.3 (TOXENV=py35)	20 Aug 2017 06:40PM UTC	93.76	Travis Job 28292.3
4	28292.4 (TOXENV=py36)	20 Aug 2017 06:48PM UTC	93.76	Travis Job 28292.4
5	28292.5 (TOXENV=requirements)	20 Aug 2017 06:42PM UTC		Travis Job 28292.5

Source Files on build 28292

Detailed source file information is not available for this build.

home-assistant / home-assistant / 28292
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 28292

home-assistant / home-assistant / 28292 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 28292

home-assistant / home-assistant / 28292
94%

README BADGES
x