1
62%
master: 57%

Ran 04 Aug 2017 01:57PM UTC

Files 176

Run time 7s

Badge

Embed ▾

Committed 04 Aug 2017 01:48PM UTC coverage: 61.265% (-0.003%) from 61.268%

Job # TEST_DB=SQLite

Build Type

push

travis-ci

Committed by

atodorov

Commit Message

Don't wrap Prompt.render with HttpResponse

Prompt.render calls django.shortcuts.render which returns an
HttpResponse. When HttpResponse.__init__ is executed the content
is assigned to self.content via a setter method. This method
accepts either string content (rendered from templates) or
iterator.

When we wrap Prompt.render with additional HttpResponse the
retrurned content is the same but because now we pass an iterator
to the __init__() method another branch of the code is executed.
This branch calls content.close() which in this case is
HttpResponse.close() which fires `signals.request_finished` which
in turn closes the connection to the database.

During testing this is a problem because the connection is closed
right after the offending view returns, which is in the middle of
a test case method. Because the DB connection is now closed all
subsequent queries that are used to assert the application state
(e.g. User.objects.count()) fail with TransactionManagementError!

Run Details

7051 of 11509 relevant lines covered (61.27%)

0.61 hits per line

MrSenko / Kiwi / 192 / 1
62%
master: 57%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 192.1 (TEST_DB=SQLite)

MrSenko / Kiwi / 192 / 1 62% master: 57%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 192.1 (TEST_DB=SQLite)

MrSenko / Kiwi / 192 / 1
62%
master: 57%

README BADGES
x