192
62%
master: 57%

Ran 04 Aug 2017 01:57PM UTC

Jobs 4

Files 176

Run time 48s

Badge

Embed ▾

pending completion

Build # 192

Build Type

push

travis-ci

Committed by

atodorov

Commit Message

Don't wrap Prompt.render with HttpResponse

Prompt.render calls django.shortcuts.render which returns an
HttpResponse. When HttpResponse.__init__ is executed the content
is assigned to self.content via a setter method. This method
accepts either string content (rendered from templates) or
iterator.

When we wrap Prompt.render with additional HttpResponse the
retrurned content is the same but because now we pass an iterator
to the __init__() method another branch of the code is executed.
This branch calls content.close() which in this case is
HttpResponse.close() which fires `signals.request_finished` which
in turn closes the connection to the database.

During testing this is a problem because the connection is closed
right after the offending view returns, which is in the middle of
a test case method. Because the DB connection is now closed all
subsequent queries that are used to assert the application state
(e.g. User.objects.count()) fail with TransactionManagementError!

Run Details

7059 of 11509 relevant lines covered (61.33%)

2.45 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	192.1 (TEST_DB=SQLite)	04 Aug 2017 01:57PM UTC	61.27	Travis Job 192.1
2	192.2 (TEST_DB=MySQL)	04 Aug 2017 01:57PM UTC	61.27	Travis Job 192.2
3	192.3 (TEST_DB=Postgres)	04 Aug 2017 01:57PM UTC	61.27	Travis Job 192.3
4	192.4 (TEST_DB=MariaDB)	04 Aug 2017 01:57PM UTC	61.27	Travis Job 192.4

Source Files on build 192

Detailed source file information is not available for this build.

MrSenko / Kiwi / 192
62%
master: 57%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 192

MrSenko / Kiwi / 192 62% master: 57%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 192

MrSenko / Kiwi / 192
62%
master: 57%

README BADGES
x