1
88%
master: 88%

Ran 11 Sep 2014 06:48PM UTC

Files 16

Run time 13s

Badge

Embed ▾

Committed 11 Sep 2014 06:38PM UTC coverage: 93.341% (+0.008%) from 93.333%

Job # 236.1

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

make sure plugin env vars are always masked

Summary:
We had code for this before, but it wasn't tested. It turns out we were
setting the literal field names ('url') instead of the formatted field
names ('PERU_MODULE_URL'). We didn't notice this before, because we
were still using `os.environ.get` for our optional fields, which doesn't
fail on a missing variable. Get rid of those calls.

Test Plan:
Now that we're using `os.environ[]` everywhere, we should notice if this
breaks.

Reviewers: sean

Differential Revision: https://phabricator.buildinspace.com/D88

Run Details

855 of 916 relevant lines covered (93.34%)

0.93 hits per line

buildinspace / peru / 236 / 1
88%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 236.1

buildinspace / peru / 236 / 1 88% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 236.1

buildinspace / peru / 236 / 1
88%
master: 88%

README BADGES
x