236
88%

Ran 11 Sep 2014 06:48PM UTC

Jobs 2

Files 16

Run time 2min

Badge

Embed ▾

pending completion

Build # 236

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

make sure plugin env vars are always masked

Summary:
We had code for this before, but it wasn't tested. It turns out we were
setting the literal field names ('url') instead of the formatted field
names ('PERU_MODULE_URL'). We didn't notice this before, because we
were still using `os.environ.get` for our optional fields, which doesn't
fail on a missing variable. Get rid of those calls.

Test Plan:
Now that we're using `os.environ[]` everywhere, we should notice if this
breaks.

Reviewers: sean

Differential Revision: https://phabricator.buildinspace.com/D88

Run Details

855 of 916 relevant lines covered (93.34%)

1.87 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	236.1	11 Sep 2014 06:48PM UTC	0	93.34	Travis Job 236.1
2	236.2	11 Sep 2014 06:51PM UTC	0	93.23	Travis Job 236.2

Source Files on build 236

Detailed source file information is not available for this build.

buildinspace / peru / 236
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 236

buildinspace / peru / 236 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 236

buildinspace / peru / 236
88%

README BADGES
x