2
94%
dev: 94%

Ran 11 Jul 2017 03:03AM UTC

Files 268

Run time 9s

Badge

Embed ▾

Committed 11 Jul 2017 02:58AM UTC coverage: 93.572%. Remained the same

Job # TOXENV=py34

Build Type

push

travis-ci

Committed by

balloob

Commit Message

Allow Twitter notifications to include media (#8282)

* Allow notifications to include media, with Twitter as the first implementation. The Twitter notifier uses the Twitter-recommended async chunked media/upload approach and tries to convey the correct mime type of the media. Twitter implementation based on https://github.com/geduldig/TwitterAPI/blob/master/examples/upload_video.py.

* Changes based on balloob's review:
balloob: "Please remove this file. We fixed the issue in our tests that left this artifact."
balloob: "…prefer a guard clause"
balloob: "This is very inefficient. You are now generating up to 99 values."
balloob: "Since media_id is going to be None, why not just return None and you can remove the else."

* balloob: "Other notify platforms are using ATTR_DATA for it. That way if a platform requires extra metadata, we don't need to add extra fields. So please add it to Twitter via ATTR_DATA."

Coverage Stats

22725 of 24286 relevant lines covered (93.57%)

0.94 hits per line

home-assistant / home-assistant / 26551 / 2
94%
dev: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 26551.2 (TOXENV=py34)

home-assistant / home-assistant / 26551 / 2 94% dev: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 26551.2 (TOXENV=py34)

home-assistant / home-assistant / 26551 / 2
94%
dev: 94%

README BADGES
x