26551
94%

Ran 11 Jul 2017 03:00AM UTC

Jobs 5

Files 268

Run time 15min

Badge

Embed ▾

pending completion

Build # 26551

Build Type

push

travis-ci

Committed by

balloob

Commit Message

Allow Twitter notifications to include media (#8282)

* Allow notifications to include media, with Twitter as the first implementation. The Twitter notifier uses the Twitter-recommended async chunked media/upload approach and tries to convey the correct mime type of the media. Twitter implementation based on https://github.com/geduldig/TwitterAPI/blob/master/examples/upload_video.py.

* Changes based on balloob's review:
balloob: "Please remove this file. We fixed the issue in our tests that left this artifact."
balloob: "…prefer a guard clause"
balloob: "This is very inefficient. You are now generating up to 99 values."
balloob: "Since media_id is going to be None, why not just return None and you can remove the else."

* balloob: "Other notify platforms are using ATTR_DATA for it. That way if a platform requires extra metadata, we don't need to add extra fields. So please add it to Twitter via ATTR_DATA."

Coverage Stats

22729 of 24286 relevant lines covered (93.59%)

2.81 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	26551.1 (TOXENV=lint)	11 Jul 2017 03:15AM UTC		Travis Job 26551.1
2	26551.2 (TOXENV=py34)	11 Jul 2017 03:03AM UTC	93.57	Travis Job 26551.2
3	26551.3 (TOXENV=py35)	11 Jul 2017 03:09AM UTC	93.57	Travis Job 26551.3
4	26551.4 (TOXENV=py36)	11 Jul 2017 03:09AM UTC	93.56	Travis Job 26551.4
5	26551.5 (TOXENV=requirements)	11 Jul 2017 03:00AM UTC		Travis Job 26551.5

Source Files on build 26551

Detailed source file information is not available for this build.

home-assistant / home-assistant / 26551
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 26551

home-assistant / home-assistant / 26551 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 26551

home-assistant / home-assistant / 26551
94%

README BADGES
x