6
70%
master: 0%

Ran 03 Jun 2017 12:26AM UTC

Files 41

Run time 4s

Badge

Embed ▾

Committed 03 Jun 2017 12:04AM UTC coverage: 69.374%. First build

Job # TOX_ENV=py27-sqlite

Build Type

push

travis-ci

Committed by

graceguo-supercat

Commit Message

fix local state 'columns'

I found a bug in VisualizeModal:
in setStateFromProps(props), we create columns object and set into state.
But setStateFromProps will be called every componentWillReceiveProps, which means when user close Modal, open Modal etc, it will reset columns state to original props. As a result if user changed any checkbox, then close and re-open modal, his previous change will lost. This thing will become more annoying when mixed with redux updating its state.

I think we should keep 'columns' as a local state, and it should remember states even after user close Modal and reopen it. my fix is just calling setStateFromProps from constructor, not from every componentWillReceiveProps.

Run Details

4322 of 6230 relevant lines covered (69.37%)

0.69 hits per line

airbnb / superset / 25 / 6
70%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 25.6 (TOX_ENV=py27-sqlite)

airbnb / superset / 25 / 6 70% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 25.6 (TOX_ENV=py27-sqlite)

airbnb / superset / 25 / 6
70%
master: 0%

README BADGES
x