25
70%
master: 0%

Ran 03 Jun 2017 12:25AM UTC

Jobs 4

Files 41

Run time 2min

Badge

Embed ▾

pending completion

Build # 25

Build Type

push

travis-ci

Committed by

graceguo-supercat

Commit Message

fix local state 'columns'

I found a bug in VisualizeModal:
in setStateFromProps(props), we create columns object and set into state.
But setStateFromProps will be called every componentWillReceiveProps, which means when user close Modal, open Modal etc, it will reset columns state to original props. As a result if user changed any checkbox, then close and re-open modal, his previous change will lost. This thing will become more annoying when mixed with redux updating its state.

I think we should keep 'columns' as a local state, and it should remember states even after user close Modal and reopen it. my fix is just calling setStateFromProps from constructor, not from every componentWillReceiveProps.

Run Details

4342 of 6230 relevant lines covered (69.7%)

2.78 hits per line

Jobs

ID	Job ID	Ran	Coverage
3	25.3 (TOX_ENV=py34-postgres)	03 Jun 2017 12:27AM UTC	69.44	Travis Job 25.3
4	25.4 (TOX_ENV=py34-sqlite)	03 Jun 2017 12:25AM UTC	69.39	Travis Job 25.4
5	25.5 (TOX_ENV=py27-mysql)	03 Jun 2017 12:25AM UTC	69.44	Travis Job 25.5
6	25.6 (TOX_ENV=py27-sqlite)	03 Jun 2017 12:26AM UTC	69.37	Travis Job 25.6

Source Files on build 25

Detailed source file information is not available for this build.

airbnb / superset / 25
70%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 25

airbnb / superset / 25 70% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 25

airbnb / superset / 25
70%
master: 0%

README BADGES
x