2
96%
master: 97%

Ran 18 May 2017 11:53PM UTC

Files 4

Run time 0s

Badge

Embed ▾

Committed 18 May 2017 11:51PM UTC coverage: 96.35% (-0.5%) from 96.8%

Job # 18.2

Build Type

Pull #17

travis-ci

Committed by

web-flow

Commit Message

Refactor fieldHook function

Summary: I was having a hard time reasoning about the fieldHook function
so I did some refactoring to make it easier to add the embedded struct
fields.

- Remove the in-place data value updates (this appears to have been an
optimization, but, it's not necessary and make the code hard to reason
about)
- Extract getting the updates struct into it's own function.
- Extract getting decodable Struct fields into it's own function.
- Extract applying updates to the srcData into it's own function.
- Rename variables to be more explicit
- Don't use the `from` field, which should be equivalent to
srcData.Type()

Test Plan: tests pass

Pull Request Pull Request #17: Refactor fieldHook function

Run Details

264 of 274 relevant lines covered (96.35%)

1.14 hits per line

uber-go / mapdecode / 18 / 2
96%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 18.2

uber-go / mapdecode / 18 / 2 96% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 18.2

uber-go / mapdecode / 18 / 2
96%
master: 97%

README BADGES
x