uber-go / mapdecode / 18

96%

master: 97%

Pull #17

travis-ci

Refactor fieldHook function

Summary: I was having a hard time reasoning about the fieldHook function
so I did some refactoring to make it easier to add the embedded struct
fields.

- Remove the in-place data value updates (this appears to have been an
optimization, but, it's not necessary and make the code hard to reason
about)
- Extract getting the updates struct into it's own function.
- Extract getting decodable Struct fields into it's own function.
- Extract applying updates to the srcData into it's own function.
- Rename variables to be more explicit
- Don't use the `from` field, which should be equivalent to
srcData.Type()

Test Plan: tests pass

90 of 90 new or added lines in 1 file covered. (100.0%)

264 of 274 relevant lines covered (96.35%)

3.41 hits per line