1
94%
master: 94%

Ran 19 Apr 2017 08:15PM UTC

Files 69

Run time 4s

Badge

Embed ▾

Committed 19 Apr 2017 08:12PM UTC coverage: 95.066% (+4.5%) from 90.521%

Job # TOX_ENV=py27

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Ldap improvements (#175)

First of all, the structure of ldap.py is now simplified. The class is dropped
and replaced by a few module level functions which are easier to understand.

Next the functions themselves have been rearranged to be easier to test.
Some premature optimization has been removed: The updating of all users
now uses the same function as the one for one user only, since there were not
really noticable performance differences. Again, this simplifies testing.

Additionally repaired escape sequences. Either '\..' or r'\..' works, but r'\..' was to much ;)

Speaking of testing: Using mock, all ldap functions are now tested.
There still are some integration tests to verify everything actually works with the
eth ldap.

Finally a few changes in bootstrap, cli and sessions to use the new functions.

After all I am quite happy with this version now. A few points are still up for improvement and I have added them to ldap.py, but over all the code is much simpler and better tested now, which is nice.

Run Details

2948 of 3101 relevant lines covered (95.07%)

0.95 hits per line

amiv-eth / amivapi / 181 / 1
94%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 181.1 (TOX_ENV=py27)

amiv-eth / amivapi / 181 / 1 94% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 181.1 (TOX_ENV=py27)

amiv-eth / amivapi / 181 / 1
94%
master: 94%

README BADGES
x