181
94%

Ran 19 Apr 2017 08:14PM UTC

Jobs 4

Files 69

Run time 4min

Badge

Embed ▾

pending completion

Build # 181

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Ldap improvements (#175)

First of all, the structure of ldap.py is now simplified. The class is dropped
and replaced by a few module level functions which are easier to understand.

Next the functions themselves have been rearranged to be easier to test.
Some premature optimization has been removed: The updating of all users
now uses the same function as the one for one user only, since there were not
really noticable performance differences. Again, this simplifies testing.

Additionally repaired escape sequences. Either '\..' or r'\..' works, but r'\..' was to much ;)

Speaking of testing: Using mock, all ldap functions are now tested.
There still are some integration tests to verify everything actually works with the
eth ldap.

Finally a few changes in bootstrap, cli and sessions to use the new functions.

After all I am quite happy with this version now. A few points are still up for improvement and I have added them to ldap.py, but over all the code is much simpler and better tested now, which is nice.

Run Details

2951 of 3101 relevant lines covered (95.16%)

2.85 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	181.1 (TOX_ENV=py27)	19 Apr 2017 08:15PM UTC	95.07	Travis Job 181.1
2	181.2 (TOX_ENV=py35)	19 Apr 2017 08:16PM UTC	95.13	Travis Job 181.2
3	181.3 (TOX_ENV=pypy)	19 Apr 2017 08:19PM UTC	95.1	Travis Job 181.3
4	181.4 (TOX_ENV=flake8)	19 Apr 2017 08:14PM UTC		Travis Job 181.4

Source Files on build 181

Detailed source file information is not available for this build.

amiv-eth / amivapi / 181
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 181

amiv-eth / amivapi / 181 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 181

amiv-eth / amivapi / 181
94%

README BADGES
x