4
88%
dev: 88%

Ran 24 Feb 2017 11:34PM UTC

Files 44

Run time 4s

Badge

Embed ▾

Committed 24 Feb 2017 11:28PM UTC coverage: 87.235% (+0.6%) from 86.63%

Job # 3113.4

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Only create Connection object for active TChannel connections (#587)

Currently, we create a Connection object as soon as we have a TCP
connection, and then we try to add more information (such as remote peer
information) to the logging context after the init handshake. This can
lead to data races since we're modifying the logging context while
other goroutines may be logging messages with the same context.

Instead of using locks for the logging context, instead separate the
handshake phase of connections out of Connection.

Fixes #584

Run Details

4237 of 4857 relevant lines covered (87.23%)

2941.38 hits per line

uber / tchannel-go / 3113 / 4
88%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3113.4

uber / tchannel-go / 3113 / 4 88% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3113.4

uber / tchannel-go / 3113 / 4
88%
dev: 88%

README BADGES
x