3113
88%

Ran 24 Feb 2017 11:30PM UTC

Jobs 4

Files 45

Run time 3min

Badge

Embed ▾

pending completion

Build # 3113

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Only create Connection object for active TChannel connections (#587)

Currently, we create a Connection object as soon as we have a TCP
connection, and then we try to add more information (such as remote peer
information) to the logging context after the init handshake. This can
lead to data races since we're modifying the logging context while
other goroutines may be logging messages with the same context.

Instead of using locks for the logging context, instead separate the
handshake phase of connections out of Connection.

Fixes #584

Run Details

4280 of 4861 relevant lines covered (88.05%)

11873.49 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3113.1	24 Feb 2017 11:31PM UTC	87.69	Travis Job 3113.1
2	3113.2	24 Feb 2017 11:31PM UTC	87.2	Travis Job 3113.2
3	3113.3	24 Feb 2017 11:30PM UTC	87.85	Travis Job 3113.3
4	3113.4	24 Feb 2017 11:34PM UTC	87.23	Travis Job 3113.4

Source Files on build 3113

Detailed source file information is not available for this build.

uber / tchannel-go / 3113
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3113

uber / tchannel-go / 3113 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3113

uber / tchannel-go / 3113
88%

README BADGES
x