3
98%
devel: 98%

Ran 21 Feb 2017 10:52PM UTC

Files 22

Run time 1s

Badge

Embed ▾

Committed 21 Feb 2017 10:50PM UTC coverage: 97.552% (+0.001%) from 97.551%

Job # AWS_SECRET_ACCESS_KEY=fake_key AWS_ACCESS_KEY_ID=fake_id

Build Type

Pull #234

travis-ci

Committed by

web-flow

Commit Message

Make sessions threadsafe

I ran into the thread safety issue described here:

https://github.com/jlafon/PynamoDB/issues/153

According to boto3's docs, each thread should have its own session instance:

http://boto3.readthedocs.io/en/latest/guide/resources.html#multithreading

I resolved this by modifying the session property on the connection
class. It makes self._session into a thread local variable, and
attaches a session to self._session.session. The session property still
has the same behavior, but now it's creating a session on a
per-connection-per-thread basis instead of just on a per-thread basis.

This issue was intermittent to begin with, and I hadn't figured out a
way to reliably reproduce it, or I would have written a test. It still
passes PynamoDB's unit tests, and I haven't run into the thread safety
issue described in #153 since I've been running the patched version.

Pull Request Pull Request #234: Make sessions threadsafe

Run Details

4821 of 4942 relevant lines covered (97.55%)

0.98 hits per line

jlafon / PynamoDB / 788 / 3
98%
devel: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 788.3 (AWS_SECRET_ACCESS_KEY=fake_key AWS_ACCESS_KEY_ID=fake_id)

jlafon / PynamoDB / 788 / 3 98% devel: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 788.3 (AWS_SECRET_ACCESS_KEY=fake_key AWS_ACCESS_KEY_ID=fake_id)

jlafon / PynamoDB / 788 / 3
98%
devel: 98%

README BADGES
x