788
98%

Ran 21 Feb 2017 10:51PM UTC

Jobs 5

Files 22

Run time 5min

Badge

Embed ▾

pending completion

Build # 788

Build Type

Pull #234

travis-ci

Committed by

web-flow

Commit Message

Make sessions threadsafe

I ran into the thread safety issue described here:

https://github.com/jlafon/PynamoDB/issues/153

According to boto3's docs, each thread should have its own session instance:

http://boto3.readthedocs.io/en/latest/guide/resources.html#multithreading

I resolved this by modifying the session property on the connection
class. It makes self._session into a thread local variable, and
attaches a session to self._session.session. The session property still
has the same behavior, but now it's creating a session on a
per-connection-per-thread basis instead of just on a per-thread basis.

This issue was intermittent to begin with, and I hadn't figured out a
way to reliably reproduce it, or I would have written a test. It still
passes PynamoDB's unit tests, and I haven't run into the thread safety
issue described in #153 since I've been running the patched version.

Pull Request Pull Request #234: Make sessions threadsafe

Run Details

4830 of 4942 relevant lines covered (97.73%)

4.88 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
21	100.0		pynamodb/connection/base.py

Jobs

ID	Job ID	Ran	Coverage
1	788.1 (AWS_SECRET_ACCESS_KEY=fake_key AWS_ACCESS_KEY_ID=fake_id)	21 Feb 2017 10:51PM UTC	97.51	Travis Job 788.1
2	788.2 (AWS_SECRET_ACCESS_KEY=fake_key AWS_ACCESS_KEY_ID=fake_id)	21 Feb 2017 10:55PM UTC	97.51	Travis Job 788.2
3	788.3 (AWS_SECRET_ACCESS_KEY=fake_key AWS_ACCESS_KEY_ID=fake_id)	21 Feb 2017 10:52PM UTC	97.55	Travis Job 788.3
4	788.4 (AWS_SECRET_ACCESS_KEY=fake_key AWS_ACCESS_KEY_ID=fake_id)	21 Feb 2017 10:57PM UTC	97.55	Travis Job 788.4
5	788.5 (AWS_SECRET_ACCESS_KEY=fake_key AWS_ACCESS_KEY_ID=fake_id)	21 Feb 2017 10:52PM UTC	97.55	Travis Job 788.5

Source Files on build 788

Detailed source file information is not available for this build.

jlafon / PynamoDB / 788
98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 788

jlafon / PynamoDB / 788 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 788

jlafon / PynamoDB / 788
98%

README BADGES
x