6
3%
master: 3%

Ran 20 Feb 2017 07:21PM UTC

Files 335

Run time 15s

Badge

Embed ▾

Committed 20 Feb 2017 06:46PM UTC coverage: 89.979% (-0.09%) from 90.068%

Job # TEST_SUITE=backend

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

left-sidebar: Sort pinned streams by lowercase stream name.

The pinned streams were sorted in alphabetic order (i.e. Verona appears
before devel). The reason is that after we plucked pinned streams out from
stream_data.subscribed_streams(), we didn't sort them again, so they
remained in the alphabetic order used in stream_data.

However, we did sort unpinned streams explicitly by using custom compare
function in stream_list.js (by default sort by lowercase stream name,
but when there are more than 40 subscribed streams, sort active streams
first). That's why this issue only relates to pinned streams.

Changes were made to sort pinned streams by lowercase stream name, always,
whether they are active or not (different from unpinned streams).

Tests were added to ensure this overall sort order is correct, i.e.

1. pinned streams are always sorted by lowercase stream name.
2. pinned streams are always before unpinned streams.
3. unpinned streams are sorted by lowercase stream name, if there are more
   than 40 subscribed streams, sort active streams at the top, among active
   and inactive streams, still sorted by lowercase stream name.

Fixes #3701

Run Details

26766 of 29747 relevant lines covered (89.98%)

0.9 hits per line

zulip / zulip / 12859 / 6
3%
master: 3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12859.6 (TEST_SUITE=backend)

zulip / zulip / 12859 / 6 3% master: 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 12859.6 (TEST_SUITE=backend)

zulip / zulip / 12859 / 6
3%
master: 3%

README BADGES
x