12859
3%

Ran 20 Feb 2017 07:10PM UTC

Jobs 7

Files 335

Run time 15min

Badge

Embed ▾

pending completion

Build # 12859

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

left-sidebar: Sort pinned streams by lowercase stream name.

The pinned streams were sorted in alphabetic order (i.e. Verona appears
before devel). The reason is that after we plucked pinned streams out from
stream_data.subscribed_streams(), we didn't sort them again, so they
remained in the alphabetic order used in stream_data.

However, we did sort unpinned streams explicitly by using custom compare
function in stream_list.js (by default sort by lowercase stream name,
but when there are more than 40 subscribed streams, sort active streams
first). That's why this issue only relates to pinned streams.

Changes were made to sort pinned streams by lowercase stream name, always,
whether they are active or not (different from unpinned streams).

Tests were added to ensure this overall sort order is correct, i.e.

1. pinned streams are always sorted by lowercase stream name.
2. pinned streams are always before unpinned streams.
3. unpinned streams are sorted by lowercase stream name, if there are more
   than 40 subscribed streams, sort active streams at the top, among active
   and inactive streams, still sorted by lowercase stream name.

Fixes #3701

Run Details

26793 of 29747 relevant lines covered (90.07%)

1.8 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	12859.1 (TEST_SUITE=static-analysis)	20 Feb 2017 07:10PM UTC		Travis Job 12859.1
2	12859.2 (TEST_SUITE=production)	20 Feb 2017 07:18PM UTC		Travis Job 12859.2
3	12859.3 (TEST_SUITE=production)	20 Feb 2017 07:17PM UTC		Travis Job 12859.3
4	12859.4 (TEST_SUITE=frontend)	20 Feb 2017 07:12PM UTC		Travis Job 12859.4
5	12859.5 (TEST_SUITE=frontend)	20 Feb 2017 07:17PM UTC		Travis Job 12859.5
6	12859.6 (TEST_SUITE=backend)	20 Feb 2017 07:21PM UTC	89.98	Travis Job 12859.6
7	12859.7 (TEST_SUITE=backend)	20 Feb 2017 07:25PM UTC	90.07	Travis Job 12859.7

Source Files on build 12859

Detailed source file information is not available for this build.

zulip / zulip / 12859
3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12859

zulip / zulip / 12859 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12859

zulip / zulip / 12859
3%

README BADGES
x