Instagram
/
IGListKit
/
1015
/
9
100%
master: 100%
master: 100%
|
Ran
|
Files
24
|
Run time
1s
|
Badge
Embed ▾
README BADGES
|
coverage: 98.707% (+0.07%) from 98.64%
push
travis-ci
facebook-github-botHandle nil section controllers from data source Summary: Removing the assert and handling `nil` section controllers. This wont effect Swift code which demands a non-optional section controller, but Objective-C is more nuanced. There is evidence that some callers do not have a default state and are returning `nil`. Unfortunately this will [OOB here](https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListSectionMap.m#L63) if using the original `objects` array provided by the data source. Instead we prune the array, only allowing in objects that have a matching section controller. Fixes t15773862 internally. - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes https://github.com/Instagram/IGListKit/pull/488 Reviewed By: dshahidehpour Differential Revision: D4553886 Pulled By: rnystrom fbshipit-source-id: a473a99b5
3053 of 3093 relevant lines covered (98.71%)
280.86 hits per line
