6
90%
master: 90%

Ran 12 Jan 2017 07:19PM CUT

Files 135

Run time 9s

Badge

Embed ▾

Committed 12 Jan 2017 07:13PM CUT coverage: 90.138%. Remained the same

Job # DEPS=latest TEST_COVERAGE=true

Build Type

Pull #133

travis-ci

Committed by

web-flow

Commit Message

fix mistakes, suggest improvements in collections.md

specifically,  I have:

- fixed references to  Zend\Stdlib\Hydrator\ClassMethods
- fixed a typo allws -> allows
- suggested a line in the controller to set the form's action attribute to submit to itself rather setting it to the 'home'  route in the viewscript
- in the controller, wrapped the var_dump() in <pre> tags for legibility
- fixed a syntax error in the ProductFieldset getInputerFilterSpecification() (an array was opened with the old syntax but closed with the new)
- removed a line from the viewscript that gratuitously re-renders $this->formRow($product->get('name'));

As a side note, I was going to propose a revision to the part about not being able to submit the form with a Collection having fewer elements than it began with. I am not sure that's the case. The 'allow_remove' option seems to be just for that. But I haven't been able to prove it because at the moment I am struggling with my Doctrine and can't get it to remove entities from the N side of my 1:N.

Hope this helps :-)

Pull Request Pull Request #133: fix mistakes, suggest improvements in collections.md

Run Details

3857 of 4279 relevant lines covered (90.14%)

128.95 hits per line

Source Files on job 259.6 (DEPS=latest TEST_COVERAGE=true)

Show entries

Search:

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	src/View/Helper/File/FormFileApcProgress.php	25 - 419	1 - 273	0 - 20	1 - 253	0.0 - 1.0
0.0	...ormElementManager/FormElementManagerV2Polyfill.php	293 + 269	55 + 40	0 - 12	55 + 52	0.0 - 1.0
0.0	src/Module.php	45 - 131	18 - 80	0 - 34	18 - 46	0.0 - 1.0
37.5	src/Annotation/AbstractArrayAnnotation.php	38 + 19	8 - 4	3 - 1	5 - 3	19.0 + 18
37.5	src/Annotation/AbstractStringAnnotation.php	38 + 19	8 - 4	3 - 1	5 - 3	22.0 + 21
37.5	src/Annotation/AbstractArrayOrStringAnnotation.php	38 - 78	8 - 43	3 - 5	5 - 38	13.0 + 12
41.18	src/ElementFactory.php	133 + 124	34 + 28	14 + 8	20 + 20	120.0 + 119
54.55	src/Annotation/Required.php	61 + 33	11 - 2	6 - 6	5 + 4	14.0 + 12
60.26	src/Element/MonthSelect.php	361 + 357	78 + 75	47 + 44	31 + 31	12.0 + 11
67.01	src/Element/DateTimeSelect.php	339 - 154	97 - 162	65 - 51	32 - 111	4.0 + 3

Showing 1 to 10 of 135 entries

zendframework / zend-form / 259 / 6
90%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 259.6 (DEPS=latest TEST_COVERAGE=true)

zendframework / zend-form / 259 / 6 90% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 259.6 (DEPS=latest TEST_COVERAGE=true)

zendframework / zend-form / 259 / 6
90%
master: 90%

README BADGES
x