6
90%
master: 90%

Ran 12 Jan 2017 07:19PM UTC

Files 135

Run time 9s

Badge

Embed ▾

Committed 12 Jan 2017 07:13PM UTC coverage: 90.138%. Remained the same

Job # DEPS=latest TEST_COVERAGE=true

Build Type

Pull #133

travis-ci

Committed by

web-flow

Commit Message

fix mistakes, suggest improvements in collections.md

specifically,  I have:

- fixed references to  Zend\Stdlib\Hydrator\ClassMethods
- fixed a typo allws -> allows
- suggested a line in the controller to set the form's action attribute to submit to itself rather setting it to the 'home'  route in the viewscript
- in the controller, wrapped the var_dump() in <pre> tags for legibility
- fixed a syntax error in the ProductFieldset getInputerFilterSpecification() (an array was opened with the old syntax but closed with the new)
- removed a line from the viewscript that gratuitously re-renders $this->formRow($product->get('name'));

As a side note, I was going to propose a revision to the part about not being able to submit the form with a Collection having fewer elements than it began with. I am not sure that's the case. The 'allow_remove' option seems to be just for that. But I haven't been able to prove it because at the moment I am struggling with my Doctrine and can't get it to remove entities from the N side of my 1:N.

Hope this helps :-)

Pull Request Pull Request #133: fix mistakes, suggest improvements in collections.md

Coverage Stats

3857 of 4279 relevant lines covered (90.14%)

128.95 hits per line

zendframework / zend-form / 259 / 6
90%
master: 90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 259.6 (DEPS=latest TEST_COVERAGE=true)

zendframework / zend-form / 259 / 6 90% master: 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 259.6 (DEPS=latest TEST_COVERAGE=true)

zendframework / zend-form / 259 / 6
90%
master: 90%

README BADGES
x