• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

zendframework / zend-form / 259
90%

Build:
DEFAULT BRANCH: master
Ran 12 Jan 2017 07:19PM UTC
Jobs 1
Files 135
Run time 11s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
259

Pull #133

travis-ci

web-flow
fix mistakes, suggest improvements in collections.md

specifically,  I have:

- fixed references to  Zend\Stdlib\Hydrator\ClassMethods
- fixed a typo allws -> allows
- suggested a line in the controller to set the form's action attribute to submit to itself rather setting it to the 'home'  route in the viewscript
- in the controller, wrapped the var_dump() in <pre> tags for legibility
- fixed a syntax error in the ProductFieldset getInputerFilterSpecification() (an array was opened with the old syntax but closed with the new)
- removed a line from the viewscript that gratuitously re-renders $this->formRow($product->get('name'));

As a side note, I was going to propose a revision to the part about not being able to submit the form with a Collection having fewer elements than it began with. I am not sure that's the case. The 'allow_remove' option seems to be just for that. But I haven't been able to prove it because at the moment I am struggling with my Doctrine and can't get it to remove entities from the N side of my 1:N.

Hope this helps :-)
Pull Request #133: fix mistakes, suggest improvements in collections.md

3857 of 4279 relevant lines covered (90.14%)

128.95 hits per line

Jobs
ID Job ID Ran Files Coverage
6 259.6 (DEPS=latest TEST_COVERAGE=true) 12 Jan 2017 07:16PM UTC 0
90.14
Travis Job 259.6
Source Files on build 259
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #259
  • Pull Request #133
  • PR Base - master (#244)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc