2
93%
development: 93%

Ran 10 Jan 2017 10:42AM UTC

Files 13

Run time 0s

Badge

Embed ▾

Committed 10 Jan 2017 10:39AM UTC coverage: 85.427% (+0.02%) from 85.403%

Job # COVERAGE="YES" TYPO3_VERSION="^8.4.1"

Build Type

push

travis-ci

Committed by

NamelessCoder

Commit Message

[BUGFIX] Fix inherited properties overriding in sub-pages (#336)

The first parameter passed to the function `getInheritedPropertyValueByDottedPath()`
was a full record array, when it should be a configuration array.

This results in the inherited configuration value always being equal to `null`,
and forcing the value to be submitted in each and every sub-page FlexForm. It
means that the inheritance was break for every page that was updated.

When changing the value of a configuration value for a root page, all its
sub-pages that were saved once were not updated.

This commit fixes this bug by actually sending the configuration to the
function.

A nice add-on would be to create an extension upgrade script that processes the
entire page tree to fix the corrupted data (proposed by @NamelessCoder). :+1:

Run Details

510 of 597 relevant lines covered (85.43%)

2.65 hits per line

FluidTYPO3 / fluidpages / 659 / 2
93%
development: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 659.2 (COVERAGE="YES" TYPO3_VERSION="^8.4.1")

FluidTYPO3 / fluidpages / 659 / 2 93% development: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 659.2 (COVERAGE="YES" TYPO3_VERSION="^8.4.1")

FluidTYPO3 / fluidpages / 659 / 2
93%
development: 93%

README BADGES
x