659
93%

Ran 10 Jan 2017 10:41AM UTC

Jobs 2

Files 13

Run time 7s

Badge

Embed ▾

pending completion

Build # 659

Build Type

push

travis-ci

Committed by

NamelessCoder

Commit Message

[BUGFIX] Fix inherited properties overriding in sub-pages (#336)

The first parameter passed to the function `getInheritedPropertyValueByDottedPath()`
was a full record array, when it should be a configuration array.

This results in the inherited configuration value always being equal to `null`,
and forcing the value to be submitted in each and every sub-page FlexForm. It
means that the inheritance was break for every page that was updated.

When changing the value of a configuration value for a root page, all its
sub-pages that were saved once were not updated.

This commit fixes this bug by actually sending the configuration to the
function.

A nice add-on would be to create an extension upgrade script that processes the
entire page tree to fix the corrupted data (proposed by @NamelessCoder). :+1:

Run Details

510 of 597 relevant lines covered (85.43%)

5.3 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	659.1 (COVERAGE="YES" TYPO3_VERSION=">=7.6.13, <7.6.99")	10 Jan 2017 10:41AM UTC	0	85.43	Travis Job 659.1
2	659.2 (COVERAGE="YES" TYPO3_VERSION="^8.4.1")	10 Jan 2017 10:41AM UTC	0	85.43	Travis Job 659.2

Source Files on build 659

Detailed source file information is not available for this build.

FluidTYPO3 / fluidpages / 659
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 659

FluidTYPO3 / fluidpages / 659 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 659

FluidTYPO3 / fluidpages / 659
93%

README BADGES
x