3
88%
dev: 88%

Ran 06 Jan 2017 10:23PM UTC

Files 43

Run time 2s

Badge

Embed ▾

Committed 06 Jan 2017 10:18PM UTC coverage: 87.098% (-0.3%) from 87.387%

Job # 2953.3

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

thrift-gen: Add "namespace go" support. (#559)

Currently, if "a.thrift" includes "b.thrift" but "b.thrift" has a
"namespace go" declaration, then the Apache Thrift generated code
uses the "namespace go" value as the package name. thrift-gen was
not respecting the "namespace go" and so the generated code would
not compile.

This will also help work around the following scenario. If we had:
- b/b.thrift which includes:
    b/shared.thrift
- c/c.thrift which includes
    c/shared.thrift

If a.thrift includes "b/b.thrift", everything is OK. As soon as it tries
to include "c/c.thrift", everything breaks since the "shared" package is
overwritten by the last compiled "shared.thrift". We can work around
this by adding a "namespace go" declaration to one of the shared.thrift
file to use a unique package for each of the shared.thrift files,
without having to rename the file (Which may break a lot of existing
code).

Fixes #101

Run Details

4226 of 4852 relevant lines covered (87.1%)

3032.23 hits per line

uber / tchannel-go / 2953 / 3
88%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2953.3

uber / tchannel-go / 2953 / 3 88% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 2953.3

uber / tchannel-go / 2953 / 3
88%
dev: 88%

README BADGES
x