2953
88%

Ran 06 Jan 2017 10:23PM UTC

Jobs 4

Files 44

Run time 1min

Badge

Embed ▾

pending completion

Build # 2953

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

thrift-gen: Add "namespace go" support. (#559)

Currently, if "a.thrift" includes "b.thrift" but "b.thrift" has a
"namespace go" declaration, then the Apache Thrift generated code
uses the "namespace go" value as the package name. thrift-gen was
not respecting the "namespace go" and so the generated code would
not compile.

This will also help work around the following scenario. If we had:
- b/b.thrift which includes:
    b/shared.thrift
- c/c.thrift which includes
    c/shared.thrift

If a.thrift includes "b/b.thrift", everything is OK. As soon as it tries
to include "c/c.thrift", everything breaks since the "shared" package is
overwritten by the last compiled "shared.thrift". We can work around
this by adding a "namespace go" declaration to one of the shared.thrift
file to use a unique package for each of the shared.thrift files,
without having to rename the file (Which may break a lot of existing
code).

Fixes #101

Run Details

4254 of 4856 relevant lines covered (87.6%)

12231.62 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	2953.1	06 Jan 2017 10:23PM UTC	87.06	Travis Job 2953.1
2	2953.2	06 Jan 2017 10:23PM UTC	87.19	Travis Job 2953.2
3	2953.3	06 Jan 2017 10:23PM UTC	87.1	Travis Job 2953.3
4	2953.4	06 Jan 2017 10:25PM UTC	87.14	Travis Job 2953.4

Source Files on build 2953

Detailed source file information is not available for this build.

uber / tchannel-go / 2953
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2953

uber / tchannel-go / 2953 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2953

uber / tchannel-go / 2953
88%

README BADGES
x