3
3%
master: 3%

Ran 03 Jan 2017 01:36AM UTC

Files 254

Run time 13s

Badge

Embed ▾

Committed 03 Jan 2017 12:58AM UTC coverage: 90.026% (+0.004%) from 90.022%

Job # TEST_SUITE=backend

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

Fix duplicate notifications when multiple Zulip tabs are openend.

We attempted a number of different approaches to solving this problem:

First, we tried using HTML5 local storage to keep track of which
browser should have created the desktop notification.  This failed
because one needs locking, and it doesn't appear there is an working
locking implementation for HTML5 local storage that could allow us to
do this across tabs.  See #2936 for details.

Ultimately we went with setting the message ID as a tag.  Tags are
intended to be used for updating existing desktop notifications, which
means this implementation causes new notifications to flicker in and
out sometimes when multiple tabs are open, but that certainly beats
having duplicates.

Fixes #99.

Run Details

24650 of 27381 relevant lines covered (90.03%)

0.9 hits per line

zulip / zulip / 167 / 3
3%
master: 3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 167.3 (TEST_SUITE=backend)

zulip / zulip / 167 / 3 3% master: 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 167.3 (TEST_SUITE=backend)

zulip / zulip / 167 / 3
3%
master: 3%

README BADGES
x