167
3%

Ran 03 Jan 2017 01:32AM UTC

Jobs 7

Files 254

Run time 13min

Badge

Embed ▾

pending completion

Build # 167

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

Fix duplicate notifications when multiple Zulip tabs are openend.

We attempted a number of different approaches to solving this problem:

First, we tried using HTML5 local storage to keep track of which
browser should have created the desktop notification.  This failed
because one needs locking, and it doesn't appear there is an working
locking implementation for HTML5 local storage that could allow us to
do this across tabs.  See #2936 for details.

Ultimately we went with setting the message ID as a tag.  Tags are
intended to be used for updating existing desktop notifications, which
means this implementation causes new notifications to flicker in and
out sometimes when multiple tabs are open, but that certainly beats
having duplicates.

Fixes #99.

Run Details

24654 of 27381 relevant lines covered (90.04%)

1.8 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	167.1 (TEST_SUITE=frontend)	03 Jan 2017 01:34AM UTC		Travis Job 167.1
2	167.2 (TEST_SUITE=frontend)	03 Jan 2017 01:34AM UTC		Travis Job 167.2
3	167.3 (TEST_SUITE=backend)	03 Jan 2017 01:36AM UTC	90.03	Travis Job 167.3
4	167.4 (TEST_SUITE=backend)	03 Jan 2017 01:37AM UTC	90.02	Travis Job 167.4
5	167.5 (TEST_SUITE=static-analysis)	03 Jan 2017 01:32AM UTC		Travis Job 167.5
6	167.6 (TEST_SUITE=production)	03 Jan 2017 01:45AM UTC		Travis Job 167.6
7	167.7 (TEST_SUITE=production)	03 Jan 2017 01:45AM UTC		Travis Job 167.7

Source Files on build 167

Detailed source file information is not available for this build.

zulip / zulip / 167
3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 167

zulip / zulip / 167 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 167

zulip / zulip / 167
3%

README BADGES
x