2
100%
master: 100%

Ran 22 Dec 2016 12:15AM UTC

Files 2

Run time 0s

Badge

Embed ▾

Committed 22 Dec 2016 12:14AM UTC coverage: 100.0%. Remained the same

Job # 61.2

Build Type

Pull #29

travis-ci

Committed by

web-flow

Commit Message

Wait on correct Promise in subscription

I'm not a Promise expert, but the previous code at least read like it was
possible for the Promise returned by subscribe to resolve once all the
this.pubsub.subscribe Promises resolved but before all of the "push onto
this.subscriptions" Promises resolved.  If unsubscribe was called too quickly,
you could in theory end up calling one of those "push" functions after the
`delete this.subscriptions[subId]` line and crashing.

In practice the old code does appear to work but this code more accurately shows
the intentions.

Pull Request Pull Request #29: Wait on correct Promise in subscription

Run Details

96 of 96 relevant lines covered (100.0%)

7.69 hits per line

apollostack / graphql-subscriptions / 61 / 2
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 61.2

apollostack / graphql-subscriptions / 61 / 2 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 61.2

apollostack / graphql-subscriptions / 61 / 2
100%
master: 100%

README BADGES
x