61
100%

Ran 22 Dec 2016 12:15AM UTC

Jobs 2

Files 2

Run time 13s

Badge

Embed ▾

pending completion

Build # 61

Build Type

Pull #29

travis-ci

Committed by

web-flow

Commit Message

Wait on correct Promise in subscription

I'm not a Promise expert, but the previous code at least read like it was
possible for the Promise returned by subscribe to resolve once all the
this.pubsub.subscribe Promises resolved but before all of the "push onto
this.subscriptions" Promises resolved.  If unsubscribe was called too quickly,
you could in theory end up calling one of those "push" functions after the
`delete this.subscriptions[subId]` line and crashing.

In practice the old code does appear to work but this code more accurately shows
the intentions.

Pull Request Pull Request #29: Wait on correct Promise in subscription

Run Details

96 of 96 relevant lines covered (100.0%)

15.38 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	61.1	22 Dec 2016 12:15AM UTC	0	100.0	Travis Job 61.1
2	61.2	22 Dec 2016 12:15AM UTC	0	100.0	Travis Job 61.2

apollostack / graphql-subscriptions / 61
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 61

apollostack / graphql-subscriptions / 61 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 61

apollostack / graphql-subscriptions / 61
100%

README BADGES
x