1
100%
master: 100%

Ran 21 Dec 2016 04:23PM UTC

Files 3

Run time 0s

Badge

Embed ▾

Committed 21 Dec 2016 03:33PM UTC coverage: 100.0%. Remained the same

Job # 60.1

Build Type

Pull #20

travis-ci

Committed by

web-flow

Commit Message

Add option to skip simplification

Summary
-------
This diff adds a parameter to the constructor of the `Fraction` class
called `$shouldSimplify`. When set to false it skips the last step of
calling the `simplify()` function.

The parameter is defaulted to `true` so there is no change in existing
behavior.

Test Plan
--------
See new unit test.

Questions
---------
- My other thought was making `simplify()` protected so that we could
  subclass it and remove the simplification functionality in a subclass.

Context
-------
We want to be able to validate that a string is "fraction-like", but
keep the format that the string was originally in.

Pull Request Pull Request #20: Add option to skip simplification

Run Details

105 of 105 relevant lines covered (100.0%)

31.71 hits per line

phospr / fraction / 60 / 1
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 60.1

phospr / fraction / 60 / 1 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 60.1

phospr / fraction / 60 / 1
100%
master: 100%

README BADGES
x