60
100%

Ran 21 Dec 2016 04:22PM UTC

Jobs 3

Files 3

Run time 16s

Badge

Embed ▾

pending completion

Build # 60

Build Type

Pull #20

travis-ci

Committed by

web-flow

Commit Message

Add option to skip simplification

Summary
-------
This diff adds a parameter to the constructor of the `Fraction` class
called `$shouldSimplify`. When set to false it skips the last step of
calling the `simplify()` function.

The parameter is defaulted to `true` so there is no change in existing
behavior.

Test Plan
--------
See new unit test.

Questions
---------
- My other thought was making `simplify()` protected so that we could
  subclass it and remove the simplification functionality in a subclass.

Context
-------
We want to be able to validate that a string is "fraction-like", but
keep the format that the string was originally in.

Pull Request Pull Request #20: Add option to skip simplification

Run Details

105 of 105 relevant lines covered (100.0%)

95.14 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	60.1	21 Dec 2016 04:23PM UTC	100.0	Travis Job 60.1
2	60.2	21 Dec 2016 04:22PM UTC	100.0	Travis Job 60.2
3	60.3	21 Dec 2016 04:23PM UTC	100.0	Travis Job 60.3

Source Files on build 60

Detailed source file information is not available for this build.

phospr / fraction / 60
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 60

phospr / fraction / 60 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 60

phospr / fraction / 60
100%

README BADGES
x