5
94%
master: 95%

Ran 21 Jun 2014 11:53AM UTC

Files 21

Run time 11s

Badge

Embed ▾

Committed 21 Jun 2014 11:46AM UTC coverage: 94.382%. Remained the same

Job # 2.1.0

Build Type

push

travis-ci

Committed by

ixti

Commit Message

Explicitly stringify readpartial result

Consuming chunked stream may lead into unexpected `nil`s at any time of
consumption. Thus we should return `nil` only when `@socket` was closed.

Chunked responses are streamed in chunks. Each (full) chunk consist of:

  BYTES CRLF
  DATA CRLF

But socket does not care about consistency of those chunk, thus it's
common when we got only first part: `BYTES CRLF`. At this point we feed
this to http_parser which does not emits `on_data` event and our own
Parser `@chunk` ivar remains `nil` after previous flush.

This is no an ideal solution. Ideally we should relay explicitly on
http_parser `#finished?` flag instead. So this should be kept in mind
upon connection exctraction and refactoring.

Resolves #137

Run Details

588 of 623 relevant lines covered (94.38%)

24.22 hits per line

tarcieri / http / 571 / 5
94%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 571.5 (2.1.0)

tarcieri / http / 571 / 5 94% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 571.5 (2.1.0)

tarcieri / http / 571 / 5
94%
master: 95%

README BADGES
x