571
94%
master: 95%

Ran 21 Jun 2014 11:52AM UTC

Jobs 8

Files 22

Run time 6min

Badge

Embed ▾

pending completion

Build # 571

Build Type

push

travis-ci

Committed by

ixti

Commit Message

Explicitly stringify readpartial result

Consuming chunked stream may lead into unexpected `nil`s at any time of
consumption. Thus we should return `nil` only when `@socket` was closed.

Chunked responses are streamed in chunks. Each (full) chunk consist of:

  BYTES CRLF
  DATA CRLF

But socket does not care about consistency of those chunk, thus it's
common when we got only first part: `BYTES CRLF`. At this point we feed
this to http_parser which does not emits `on_data` event and our own
Parser `@chunk` ivar remains `nil` after previous flush.

This is no an ideal solution. Ideally we should relay explicitly on
http_parser `#finished?` flag instead. So this should be kept in mind
upon connection exctraction and refactoring.

Resolves #137

Run Details

694 of 743 relevant lines covered (93.41%)

164.4 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	571.2 (1.9.2)	21 Jun 2014 11:52AM UTC	93.23	Travis Job 571.2
3	571.3 (1.9.3)	21 Jun 2014 11:52AM UTC	94.38	Travis Job 571.3
4	571.4 (2.0.0)	21 Jun 2014 11:52AM UTC	94.38	Travis Job 571.4
5	571.5 (2.1.0)	21 Jun 2014 11:53AM UTC	94.38	Travis Job 571.5
6	571.6 (rbx-2)	21 Jun 2014 11:57AM UTC	97.98	Travis Job 571.6
7	571.7 (ruby-head)	21 Jun 2014 11:55AM UTC	94.38	Travis Job 571.7
9	571.9 (jruby-19mode, JRUBY_OPTS="$JRUBY_OPTS --debug")	21 Jun 2014 11:56AM UTC	94.05	Travis Job 571.9
10	571.10 (jruby-head, JRUBY_OPTS="$JRUBY_OPTS --debug")	21 Jun 2014 11:58AM UTC	94.05	Travis Job 571.10

tarcieri / http / 571
94%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 571

tarcieri / http / 571 94% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 571

tarcieri / http / 571
94%
master: 95%

README BADGES
x