• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

daurnimator / lua-http / 390 / 18
88%
master: 88%

Build:
DEFAULT BRANCH: master
Ran 08 Dec 2016 07:36AM UTC
Files 23
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Dec 2016 07:30AM UTC coverage: 76.99% (-0.03%) from 77.024%
LUA="luajit 2.1" ZLIB=lzlib

push

travis-ci

daurnimator
http/h2_connection: Make sure h2_connection:close() actually closes the connection when called from inside the internal cqueue

The cqueues.poll() calls in h2_connection:close() meant that :close would yield to the current controller. If the current controller was the h2_connection's own cqueue, then nothing would happen until the next action was performed on the h2_connection.
As :close() is usually the *last* thing you do to the h2_connection object, this meant that the socket wouldn't be closed until the garbage collector got around to it.

This fix is to check for a 'close_me' flag upon exit from :step() or :loop() and do the :close() then.
We still need to call cqueues.poll() twice incase other cqueues were waiting on the file descriptor

3637 of 4724 relevant lines covered (76.99%)

299.67 hits per line

Source Files on job 390.18 (LUA="luajit 2.1" ZLIB=lzlib)
  • Tree
  • List 0
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 390
  • Travis Job 390.18
  • e5817afb on github
  • Prev Job for LUA="luajit 2.1" ZLIB=lzlib on master (#389.18)
  • Next Job for LUA="luajit 2.1" ZLIB=lzlib on master (#391.18)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc