390
88%

Ran 08 Dec 2016 07:32AM UTC

Jobs 19

Files 23

Run time 4min

Badge

Embed ▾

pending completion

Build # 390

Build Type

push

travis-ci

Committed by

daurnimator

Commit Message

http/h2_connection: Make sure h2_connection:close() actually closes the connection when called from inside the internal cqueue

The cqueues.poll() calls in h2_connection:close() meant that :close would yield to the current controller. If the current controller was the h2_connection's own cqueue, then nothing would happen until the next action was performed on the h2_connection.
As :close() is usually the *last* thing you do to the h2_connection object, this meant that the socket wouldn't be closed until the garbage collector got around to it.

This fix is to check for a 'close_me' flag upon exit from :step() or :loop() and do the :close() then.
We still need to call cqueues.poll() twice incase other cqueues were waiting on the file descriptor

Run Details

4695 of 5438 relevant lines covered (86.34%)

4702.76 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	390.1 (LUA="lua 5.1")	08 Dec 2016 07:32AM UTC	84.81	Travis Job 390.1
2	390.2 (LUA="lua 5.1" ZLIB=lzlib)	08 Dec 2016 07:32AM UTC	85.94	Travis Job 390.2
3	390.3 (LUA="lua 5.1" ZLIB=lua-zlib)	08 Dec 2016 07:32AM UTC	85.71	Travis Job 390.3
4	390.4 (LUA="lua 5.2")	08 Dec 2016 07:32AM UTC	84.67	Travis Job 390.4
5	390.5 (LUA="lua 5.2" ZLIB=lzlib)	08 Dec 2016 07:32AM UTC	85.79	Travis Job 390.5
6	390.6 (LUA="lua 5.2" ZLIB=lua-zlib)	08 Dec 2016 07:33AM UTC	85.57	Travis Job 390.6
7	390.7 (LUA="lua 5.3")	08 Dec 2016 07:33AM UTC	84.58	Travis Job 390.7
8	390.8 (LUA="lua 5.3" ZLIB=lzlib)	08 Dec 2016 07:33AM UTC	85.71	Travis Job 390.8
9	390.9 (LUA="lua 5.3" ZLIB=lua-zlib)	08 Dec 2016 07:33AM UTC	85.49	Travis Job 390.9
10	390.10 (LUA="lua 5.3" COMPAT53=no)	08 Dec 2016 07:33AM UTC	84.58	Travis Job 390.10
11	390.11 (LUA="luajit @")	08 Dec 2016 07:35AM UTC	75.69	Travis Job 390.11
12	390.12 (LUA="luajit @" ZLIB=lzlib)	08 Dec 2016 07:35AM UTC	76.99	Travis Job 390.12
13	390.13 (LUA="luajit @" ZLIB=lua-zlib)	08 Dec 2016 07:35AM UTC	76.74	Travis Job 390.13
14	390.14 (LUA="luajit 2.0")	08 Dec 2016 07:35AM UTC	75.69	Travis Job 390.14
15	390.15 (LUA="luajit 2.0" ZLIB=lzlib)	08 Dec 2016 07:35AM UTC	76.99	Travis Job 390.15
16	390.16 (LUA="luajit 2.0" ZLIB=lua-zlib)	08 Dec 2016 07:36AM UTC	76.74	Travis Job 390.16
17	390.17 (LUA="luajit 2.1")	08 Dec 2016 07:36AM UTC	75.69	Travis Job 390.17
18	390.18 (LUA="luajit 2.1" ZLIB=lzlib)	08 Dec 2016 07:36AM UTC	76.99	Travis Job 390.18
19	390.19 (LUA="luajit 2.1" ZLIB=lua-zlib)	08 Dec 2016 07:36AM UTC	76.74	Travis Job 390.19

Source Files on build 390

Detailed source file information is not available for this build.

daurnimator / lua-http / 390
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 390

daurnimator / lua-http / 390 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 390

daurnimator / lua-http / 390
88%

README BADGES
x