1
88%
develop: 88%

Ran 02 Dec 2016 03:40PM UTC

Files 46

Run time 3s

Badge

Embed ▾

Committed 02 Dec 2016 03:35PM UTC coverage: 84.776% (+0.5%) from 84.261%

Job # 1265.1

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

GAWB-1236: Check user permissions before modifying ACLs (#171)

* Restrict delete so that it doesn't remove the last manager permission

* Make sure test is run.
Change entity type for validation issue.

* fix error handling

* update swagger

* PR feedback: more encapulated util method, more robust test

* For edits and deletes, make sure the user cannot modify/delete their own permissions.

* Tests for the web layer

* code style + typo

* Insert/post can result in an update/put so handle that case as well.

* Only prevent post/put updates when the ACLs will be different and allow non-changes to go through.

* refactor + typo

* swagger conflict updates

* Reduce three db queries to one.

* PR Feedback

* Revert unnecessary test change

* PR feedback

* extract some logic into utility method (#173)

* code layout and refactoring

* Batch authorize before batch inserting

Run Details

813 of 959 relevant lines covered (84.78%)

0.85 hits per line

broadinstitute / agora / 1265 / 1
88%
develop: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1265.1

broadinstitute / agora / 1265 / 1 88% develop: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1265.1

broadinstitute / agora / 1265 / 1
88%
develop: 88%

README BADGES
x