broadinstitute / agora / 1265

88%

push

travis-ci

GAWB-1236: Check user permissions before modifying ACLs (#171)

* Restrict delete so that it doesn't remove the last manager permission

* Make sure test is run.
Change entity type for validation issue.

* fix error handling

* update swagger

* PR feedback: more encapulated util method, more robust test

* For edits and deletes, make sure the user cannot modify/delete their own permissions.

* Tests for the web layer

* code style + typo

* Insert/post can result in an update/put so handle that case as well.

* Only prevent post/put updates when the ACLs will be different and allow non-changes to go through.

* refactor + typo

* swagger conflict updates

* Reduce three db queries to one.

* PR Feedback

* Revert unnecessary test change

* PR feedback

* extract some logic into utility method (#173)

* code layout and refactoring

* Batch authorize before batch inserting

37 of 37 new or added lines in 3 files covered. (100.0%)

813 of 959 relevant lines covered (84.78%)

0.85 hits per line