• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

broadinstitute / agora / 1265
88%

Build:
DEFAULT BRANCH: develop
Ran 02 Dec 2016 03:40PM UTC
Jobs 1
Files 46
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1265

push

travis-ci

web-flow
GAWB-1236: Check user permissions before modifying ACLs (#171)

* Restrict delete so that it doesn't remove the last manager permission

* Make sure test is run.
Change entity type for validation issue.

* fix error handling

* update swagger

* PR feedback: more encapulated util method, more robust test

* For edits and deletes, make sure the user cannot modify/delete their own permissions.

* Tests for the web layer

* code style + typo

* Insert/post can result in an update/put so handle that case as well.

* Only prevent post/put updates when the ACLs will be different and allow non-changes to go through.

* refactor + typo

* swagger conflict updates

* Reduce three db queries to one.

* PR Feedback

* Revert unnecessary test change

* PR feedback

* extract some logic into utility method (#173)

* code layout and refactoring

* Batch authorize before batch inserting

37 of 37 new or added lines in 3 files covered. (100.0%)

813 of 959 relevant lines covered (84.78%)

0.85 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
100.0
src/main/scala/org/broadinstitute/dsde/agora/server/webservice/PerRequest.scala
Jobs
ID Job ID Ran Files Coverage
1 1265.1 02 Dec 2016 03:40PM UTC 0
84.78
Travis Job 1265.1
Source Files on build 1265
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1265
  • cf2cdc18 on github
  • Prev Build on develop (#1251)
  • Next Build on develop (#1282)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc