coniks-sys
/
coniks-go
/
1547
/
2
86%
master: 70%
master: 70%
|
Ran
|
Files
25
|
Run time
2s
|
Badge
Embed ▾
README BADGES
|
coverage: 86.007% (+0.1%) from 85.887%
push
travis-ci
c633Add verification method for DirectoryProof KeyLookup operation should not change the consistency state. Rebase master Split STR verification. - A key lookup shouldn't be altering any consistency state, other than TBs. Instead, the client would either register or monitor its binding, and that would update the consistency state (the SavedSTR). After which, it wouldn't change until the next epoch, when we do another self monitoring request. - Add a Timestamp field into ConsistencyChecks to determine which type of checks we should use (one for when we update the STR and one for the rest). - Pointer to the discussion: https://github.com/coniks-sys/coniks-go/pull/74#discussion_r87538913 (thanks @arlolra) Make some of the failure cases (proofType, error, reqType combinations) more explicit. - Also try to fail fast ASAP. Separate updating str from checking consistency Separate updating tbs from checking consistency savedSTR should not be nil when initialization Remove unused errors Consolidate hash chain verification Refactor checks - Validate (response, request type) pair in HandleResponse - Consolidate updateTBs - Remove redundant STR checks Fix fulfilled TB verification. Q: Which epoch did this lookup happen in? A: verifyFulfilledPromise must take a STR as its argument. This STR should be verified in updateSTR (e.g., epoch transitioning etc ...). Add comment for HandleResponse Re-organize code - Re-arrange methods' order. - Remove redundant params. - Remove comments which are no longer true. - Add more tests Revert 25a356b0c tb.Verify() instead (credit to @Liamsi) Revert 8e97d880c Fix 31c5b35ba Refactor
3276 of 3809 relevant lines covered (86.01%)
5050.69 hits per line
