coniks-sys / coniks-go / 1547
86%
master: 70%

LAST BUILD BRANCH: 0.1.2
DEFAULT BRANCH: master
Ran
Jobs 2
Files 25
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1547

push

travis-ci

c633 
Add verification method for DirectoryProof

KeyLookup operation should not change the consistency state.

Rebase master

Split STR verification.

- A key lookup shouldn't be altering any consistency state, other than TBs. Instead, the client would either register or monitor its binding, and that would update the consistency state (the SavedSTR). After which, it wouldn't change until the next epoch, when we do another self monitoring request.

- Add a Timestamp field into ConsistencyChecks to determine which type of checks we should use (one for when we update the STR and one for the rest).

- Pointer to the discussion: https://github.com/coniks-sys/coniks-go/pull/74#discussion_r87538913 (thanks @arlolra)

Make some of the failure cases (proofType, error, reqType combinations) more explicit.

- Also try to fail fast ASAP.

Separate updating str from checking consistency

Separate updating tbs from checking consistency

savedSTR should not be nil when initialization

Remove unused errors

Consolidate hash chain verification

Refactor checks

- Validate (response, request type) pair in HandleResponse

- Consolidate updateTBs

- Remove redundant STR checks

Fix fulfilled TB verification.

Q: Which epoch did this lookup happen in?
A: verifyFulfilledPromise must take a STR as its argument. This STR should be verified in updateSTR (e.g., epoch transitioning etc ...).

Add comment for HandleResponse

Re-organize code

- Re-arrange methods' order.

- Remove redundant params.

- Remove comments which are no longer true.

- Add more tests

Revert 25a356b0c

tb.Verify() instead (credit to @Liamsi)

Revert 8e97d880c

Fix 31c5b35ba

Refactor

3276 of 3809 relevant lines covered (86.01%)

10092.99 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1547.1 0
86.01
 Travis Job 1547.1
2 1547.2 0
86.01
 Travis Job 1547.2
Source Files on build 1547
Detailed source file information is not available for this build.