6
79%
master: 79%

Ran 16 Nov 2016 03:43PM UTC

Files 142

Run time 7s

Badge

Embed ▾

Committed 16 Nov 2016 03:27PM UTC coverage: 80.942% (-0.02%) from 80.959%

Job # jruby-9.0.5.0, RAILS=3.2.22

Build Type

Pull #4666

travis-ci

Committed by

web-flow

Commit Message

raise an error for bad filters instead of silently failing

Today I attempted to add a filter on a has-many-through association. The
UI was display nothing for my filter and AFAICS there was nothing
anywhere to tell me what the problem was.

After digging around I found that

    ActiveAdmin::Fitlers::FormBuilder#filter

simply fails quietly (returning nothing) if the type for a filter can't
be determined.

I have updated the method to raise an error instead.

Here is what failed for me (names changed):

I had this class:

```
    class Foo < ActiveRecord::Base
        has_many :bars, though: :something
    end
```

In the corresponding activeadmin resource I had this:

```
  filter :bars_id_in,
      collection: -> { Bar.all },
      as: :select, # <------- I needed to specify this
      multiple: true,
```

I needed to specify `:as`, but I had to dig into the code to figure this
out.

I have not written any specs for this. If this patch is "pre approved"
then I can write specs before you pull if desired.

Pull Request Pull Request #4666: raise an error for bad filters instead of silently failing

Coverage Stats

3007 of 3715 relevant lines covered (80.94%)

9.25 hits per line

activeadmin / activeadmin / 5127 / 6
79%
master: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5127.6 (jruby-9.0.5.0, RAILS=3.2.22)

activeadmin / activeadmin / 5127 / 6 79% master: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5127.6 (jruby-9.0.5.0, RAILS=3.2.22)

activeadmin / activeadmin / 5127 / 6
79%
master: 79%

README BADGES
x