5
100%
master: 100%

Ran 09 Nov 2016 01:43AM UTC

Files 1

Run time 0s

Badge

Embed ▾

Committed 09 Nov 2016 01:33AM UTC coverage: 100.0%. Remained the same

Job # jruby-head, JRUBY_OPTS="$JRUBY_OPTS --debug"

Build Type

Pull #5

travis-ci

Committed by

web-flow

Commit Message

Allow dynamic external interface

When defining a dynamic method name with the
`include Procto.call(:some_method_name)`, only the internal interface
can be changed. The external calls will always be `MyProctoClass::call`.
We have a use case where sometimes we want to interact with the returned
object, often to deal with it as a builder. We would like to be to able
use this in a `MyProctClass::build` style. This is to facilitate that.

I didn't know how best to structure the tests for this, so I decided to
put them in a new file. If you can think of a way they work better in
your desired test structure, I'm happy to implement that change.

I changed the rubocop.yml more accurately represent the comment that
precedes it.

I realize changing the Flog threshold is a Bad Thing, but when I tried
to decompose the two actions for the `included` hook, I didn't see that
as making the code better. I think the current setup allows for parallel
construction that makes the intent clearer.

If this is not the intended use case that you want to allow for, I'm
happy to run this on our own fork.

Pull Request Pull Request #5: Allow dynamic external interface

Run Details

20 of 20 relevant lines covered (100.0%)

4.4 hits per line

snusnu / procto / 24 / 5
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 24.5 (jruby-head, JRUBY_OPTS="$JRUBY_OPTS --debug")

snusnu / procto / 24 / 5 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 24.5 (jruby-head, JRUBY_OPTS="$JRUBY_OPTS --debug")

snusnu / procto / 24 / 5
100%
master: 100%

README BADGES
x