• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

snusnu / procto / 24
100%

Build:
DEFAULT BRANCH: master
Ran 09 Nov 2016 01:36AM UTC
Jobs 3
Files 1
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
24

Pull #5

travis-ci

web-flow
Allow dynamic external interface

When defining a dynamic method name with the
`include Procto.call(:some_method_name)`, only the internal interface
can be changed. The external calls will always be `MyProctoClass::call`.
We have a use case where sometimes we want to interact with the returned
object, often to deal with it as a builder. We would like to be to able
use this in a `MyProctClass::build` style. This is to facilitate that.

I didn't know how best to structure the tests for this, so I decided to
put them in a new file. If you can think of a way they work better in
your desired test structure, I'm happy to implement that change.

I changed the rubocop.yml more accurately represent the comment that
precedes it.

I realize changing the Flog threshold is a Bad Thing, but when I tried
to decompose the two actions for the `included` hook, I didn't see that
as making the code better. I think the current setup allows for parallel
construction that makes the intent clearer.

If this is not the intended use case that you want to allow for, I'm
happy to run this on our own fork.
Pull Request #5: Allow dynamic external interface

2 of 2 new or added lines in 1 file covered. (100.0%)

20 of 20 relevant lines covered (100.0%)

13.2 hits per line

Jobs
ID Job ID Ran Files Coverage
1 24.1 (2.3.0) 09 Nov 2016 01:36AM UTC 0
100.0
Travis Job 24.1
2 24.2 (ruby-head) 09 Nov 2016 01:36AM UTC 0
100.0
Travis Job 24.2
5 24.5 (jruby-head, JRUBY_OPTS="$JRUBY_OPTS --debug") 09 Nov 2016 01:43AM UTC 0
100.0
Travis Job 24.5
Source Files on build 24
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #24
  • Pull Request #5
  • PR Base - master (#23)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc