• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

dwaynebailey / pootle / 2088 / 1
93%
master: 95%

Build:
Build:
LAST BUILD BRANCH: cleanup/argparse_update_tmserver
DEFAULT BRANCH: master
Ran 08 Nov 2016 11:49AM UTC
Files 566
Run time 32s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Nov 2016 11:42AM UTC coverage: 92.521%. First build
TOXENV=py27-django19-sqlite PYTHONPATH=$HOME/virtualenv/python2.7.9/lib/python2.7/site-packages TOX_TESTENV_PASSENV="PYTHONPATH"

push

travis-ci

dwaynebailey
MarkupField: implement `to_python`

This fixes an ugly bug when creating and updating static pages' content.

It turns out that Django 1.9 silently introduced a backwards-incompatible change
which implemented `TextField`'s `to_python` method, and forcing coercion to text
there.

Since `MarkupField` subclasses `TextField` but didn't implement `to_python`
(rather `get_prep_value`), `TextField`'s `to_python` was being called when
cleaning the form data, hence coercing the `MarkupField` instance to a string
via its `__unicode__` method, which in turn returns the HTML-rendered version of
the raw text.

Since we want to get the raw text, we need to ensure `to_python` does the same
as before, i.e. use `get_prep_value`'s code.

Refs. https://code.djangoproject.com/ticket/24677

26598 of 28748 relevant lines covered (92.52%)

0.93 hits per line

Source Files on job 2088.1 (TOXENV=py27-django19-sqlite PYTHONPATH=$HOME/virtualenv/python2.7.9/lib/python2.7/site-packages TOX_TESTENV_PASSENV="PYTHONPATH")
  • Tree
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 2088
  • Travis Job 2088.1
  • 89ec7e33 on github
  • Next Job for TOXENV=py27-django19-sqlite PYTHONPATH=$HOME/virtualenv/python2.7.9/lib/python2.7/site-packages TOX_TESTENV_PASSENV="PYTHONPATH" on fix/pr5471 (#2089.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc