2088
93%
master: 95%

Ran 08 Nov 2016 11:47AM UTC

Jobs 4

Files 566

Run time 3min

Badge

Embed ▾

pending completion

Build # 2088

Build Type

push

travis-ci

Committed by

dwaynebailey

Commit Message

MarkupField: implement `to_python`

This fixes an ugly bug when creating and updating static pages' content.

It turns out that Django 1.9 silently introduced a backwards-incompatible change
which implemented `TextField`'s `to_python` method, and forcing coercion to text
there.

Since `MarkupField` subclasses `TextField` but didn't implement `to_python`
(rather `get_prep_value`), `TextField`'s `to_python` was being called when
cleaning the form data, hence coercing the `MarkupField` instance to a string
via its `__unicode__` method, which in turn returns the HTML-rendered version of
the raw text.

Since we want to get the raw text, we need to ensure `to_python` does the same
as before, i.e. use `get_prep_value`'s code.

Refs. https://code.djangoproject.com/ticket/24677

Run Details

26635 of 28748 relevant lines covered (92.65%)

3.04 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	2088.1 (TOXENV=py27-django19-sqlite PYTHONPATH=$HOME/virtualenv/python2.7.9/lib/python2.7/site-packages TOX_TESTENV_PASSENV="PYTHONPATH")	08 Nov 2016 11:49AM UTC	92.52	Travis Job 2088.1
2	2088.2 (TOXENV=py27-django19-mysql PYTHONPATH=$HOME/virtualenv/python2.7.9/lib/python2.7/site-packages TOX_TESTENV_PASSENV="PYTHONPATH")	08 Nov 2016 11:50AM UTC	92.54	Travis Job 2088.2
3	2088.3 (TOXENV=py27-django19-postgres PYTHONPATH=$HOME/virtualenv/python2.7.9/lib/python2.7/site-packages TOX_TESTENV_PASSENV="PYTHONPATH")	08 Nov 2016 11:49AM UTC	92.54	Travis Job 2088.3
4	2088.4 (TOXENV=project PYTHONPATH=$HOME/virtualenv/python2.7.9/lib/python2.7/site-packages TOX_TESTENV_PASSENV="PYTHONPATH")	08 Nov 2016 11:47AM UTC	25.94	Travis Job 2088.4

Source Files on build 2088

Detailed source file information is not available for this build.

dwaynebailey / pootle / 2088
93%
master: 95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2088

dwaynebailey / pootle / 2088 93% master: 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2088

dwaynebailey / pootle / 2088
93%
master: 95%

README BADGES
x