• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

graphql / graphql-js / 1373 / 1
98%
master: 98%

Build:
DEFAULT BRANCH: master
Ran 03 Nov 2016 02:54AM UTC
Files 146
Run time 7s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

03 Nov 2016 02:52AM UTC coverage: 98.124% (-0.06%) from 98.184%
1373.1

push

travis-ci

web-flow
Enforces input coercion rules. (#553)

* Enforces input coercion rules.

Before this diff, bad input to arguments and variables was often ignored and replaced with `null` rather than rejected. Now that `null` has a semantic meaning, and thanks to some recent changes to the spec (https://github.com/facebook/graphql/pull/221) - changes are necessary in order to enforce the stricter coercion rules.

This diff does the following:

* Implements the CoerceArgumentValues as described in the spec.
* Implements the CoerceVariablesValues as described in the spec.
* Alters valueFromAST and coerceValue (dual functions) to strictly enforce coercion, returning `undefined` implicitly when they fail to do so. It also fixes issues where undefined returns were being ignored as items in a list or fields in an input object.

* Fix most of the failing tests

* Fix missing data from errors

* fix lint issues

* Add full behavior test cases for valueFromAST

* additional value coercion tests

* Add appropriate list item behavior for missing vars

7951 of 8103 relevant lines covered (98.12%)

1362.45 hits per line

Source Files on job 1373.1
  • Tree
  • List 0
  • Changed 26
  • Source Changed 9
  • Coverage Changed 25
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 1373
  • Travis Job 1373.1
  • b93f0490 on github
  • Prev Job for on master (#1370.1)
  • Next Job for on master (#1378.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc