graphql / graphql-js / 1373

98%

push

travis-ci

Enforces input coercion rules. (#553)

* Enforces input coercion rules.

Before this diff, bad input to arguments and variables was often ignored and replaced with `null` rather than rejected. Now that `null` has a semantic meaning, and thanks to some recent changes to the spec (https://github.com/facebook/graphql/pull/221) - changes are necessary in order to enforce the stricter coercion rules.

This diff does the following:

* Implements the CoerceArgumentValues as described in the spec.
* Implements the CoerceVariablesValues as described in the spec.
* Alters valueFromAST and coerceValue (dual functions) to strictly enforce coercion, returning `undefined` implicitly when they fail to do so. It also fixes issues where undefined returns were being ignored as items in a list or fields in an input object.

* Fix most of the failing tests

* Fix missing data from errors

* fix lint issues

* Add full behavior test cases for valueFromAST

* additional value coercion tests

* Add appropriate list item behavior for missing vars

245 of 245 new or added lines in 8 files covered. (100.0%)

7951 of 8103 relevant lines covered (98.12%)

1362.45 hits per line