• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

graphql / graphql-js / 1373
98%

Build:
DEFAULT BRANCH: master
Ran 03 Nov 2016 02:54AM UTC
Jobs 1
Files 146
Run time 7s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1373

push

travis-ci

web-flow
Enforces input coercion rules. (#553)

* Enforces input coercion rules.

Before this diff, bad input to arguments and variables was often ignored and replaced with `null` rather than rejected. Now that `null` has a semantic meaning, and thanks to some recent changes to the spec (https://github.com/facebook/graphql/pull/221) - changes are necessary in order to enforce the stricter coercion rules.

This diff does the following:

* Implements the CoerceArgumentValues as described in the spec.
* Implements the CoerceVariablesValues as described in the spec.
* Alters valueFromAST and coerceValue (dual functions) to strictly enforce coercion, returning `undefined` implicitly when they fail to do so. It also fixes issues where undefined returns were being ignored as items in a list or fields in an input object.

* Fix most of the failing tests

* Fix missing data from errors

* fix lint issues

* Add full behavior test cases for valueFromAST

* additional value coercion tests

* Add appropriate list item behavior for missing vars

245 of 245 new or added lines in 8 files covered. (100.0%)

7951 of 8103 relevant lines covered (98.12%)

1362.45 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
10
100.0
src/execution/values.js
Jobs
ID Job ID Ran Files Coverage
1 1373.1 03 Nov 2016 02:54AM UTC 0
98.12
Travis Job 1373.1
Source Files on build 1373
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1373
  • b93f0490 on github
  • Prev Build on master (#1370)
  • Next Build on master (#1378)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc